Skip to content

Conversation

mahotd
Copy link
Contributor

@mahotd mahotd commented Nov 30, 2023

Closes #4445

Code PR

  • I have read through the contributing notes and understand the structure of the package. In particular, if my PR modifies code of plotly.graph_objects, my modifications concern the codegen files and not generated files.
  • I have added tests (if submitting a new feature or correcting a bug) or
    modified existing tests.
  • For a new feature, I have added documentation examples in an existing or
    new tutorial notebook (please see the doc checklist as well).
  • I have added a CHANGELOG entry if fixing/changing/adding anything substantial.
  • For a new feature or a change in behaviour, I have updated the relevant docstrings in the code to describe the feature or behaviour (please see the doc checklist as well).

@mahotd mahotd mentioned this pull request Nov 30, 2023
18 tasks
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Beautiful, thank you @mahotd!

@alexcjohnson alexcjohnson merged commit 99e63da into plotly:master Nov 30, 2023
@mahotd
Copy link
Contributor Author

mahotd commented Dec 1, 2023

You're welcome @alexcjohnson :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo in _subplots.py, basedatatypes.py and subplots.py
2 participants